[MPlayer-dev-eng] [GUI][PATCH] Import Playtree into Gui-PL;
Fabian Franz
FabianFranz at gmx.de
Mon Feb 3 21:39:42 CET 2003
Am Montag, 3. Februar 2003 21:37 schrieb Arpi:
> Hi,
>
> > +
> > + if (!enqueue)
> > + {
> > + gtkSet(gtkDelPl,0,0);
> > + }
> > + // Import playtree into gui
> > + import_playtree_into_gui(playtree, mconfig, 0); // Just add the
> > items to end of list
>
> why not pass 'enqueue' to import_playtree_into_gui as a parameter and let
> it to do gtkSet(gtkDelPl,0,0); instead of messing in mplayer.c with gtk???
ok, you have a point.
I missed that ...
will be changed
>
> > }
> > +
> > + if (WinID>0)
> > + {
> > + appMPlayer.subWindow.Parent=WinID;
> > + appMPlayer.mainWindow.Parent=WinID;
> > + appMPlayer.sub.x=0;
> > + appMPlayer.sub.y=0;
> > + }
> >
> > wsCreateWindow( &appMPlayer.subWindow,
> >
> > appMPlayer.sub.x,appMPlayer.sub.y,appMPlayer.sub.width,appMPlayer.sub.hei
> >ght, @@ -509,6 +517,8 @@
> > }
> > guiIntfStruct.MovieWidth=vo_dwidth;
> > guiIntfStruct.MovieHeight=vo_dheight;
> > + if (WinID>0)
> > + wsMoveWindow( &appMPlayer.mainWindow,0,0, vo_dheight);
> > }
>
> i have serious doubts that these are related to playtree...
You're doubts are correct, but perhaps you should not only read patch, but
also mail attached to patch ;)
Ok, next time I'll "emacs" them out ... :-/
But I need them for plugin, and as such they are gui-changes, that I want .so
to comment on ...
>
> > }
> > - if ( guiIntfStruct.StreamType != STREAMTYPE_PLAYLIST )
> > + //if ( guiIntfStruct.StreamType != STREAMTYPE_PLAYLIST ) // Does not
> > make problems anymore!
>
> why?
GUI had problems with playlists (endless-loop), and before my fallback there
was already fallback support for streaming playlists, which of course did
make the same problems ...
I believe .so solved it that way, that he did this hot-fix ...
But that is not necessary anymore, as PL-Fallback does now work!
>
>
> A'rpi / Astral & ESP-team
More information about the MPlayer-dev-eng
mailing list