[MPlayer-dev-eng] [PATCH] demux_real.c : make the mess even

[Arpi]

Hi,

> > > btw who managed to (and how) rev.engeneer (?) this black magic in
> > > the rm fileformat ??
> >
> > you mean the timestamps? it was me.
> > how? dumpes first 8 bytes in hex for each frame and look at it to find
> > which bits looks like a counter... easy.
> that part is actually documented :)
where?

> i originally meant the video packet parser inside a data packet
ah. it was oroginally discovered by Florian, i've cleanuped it and fixed a
few bugs.

> > > btw2 there is a hack in demux_real, because without that sound took
> > > a long time to catch up with the video. This solves it because until the
> > > first keyframe arrives, the video is still - and by that time audio will
> > > be in sync with video. Or maybe not - could some one tell me what is the
> > > real reason than?:)
> >
> > which hack?
> that with I / P frames
hmm?

> > > --- demux_real.c	2003-02-05 23:51:17.000000000 +0100
> > > +++ demux_real.c.new	2003-02-05 23:50:56.000000000 +0100
> > > @@ -317,21 +317,22 @@
> >
> > this patch is a big mess. could you send a clean patch, with no debug
> > stuff, out-commented timestamp calculation, no cosmetics?
> what is uncommented, is uncommented for a reason (timestamp calculation is 
> wrong, it made video play too fast)
why is wrong? it works for most files, without it many files won't play
correctly. it is there by reason.

> there is no debug stuff afaict 
> or you mean the number of packets reached 0 ?
yes

> that is no debug, that is a bug there, commented ;)
bug? why?

> cosmetics?
> that is one line changed by accident - deal with it, I mean it
yes

> can't be hard there are 100 printf s and gotos in the code otherwise

yes

so if you have real fixes, not hacks and not 'i uncomment this part of code
because i think it's a cool thing' then send an usable patch.


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu
    "However, many people beg for its inclusion in Debian. Why?" - Gabucino
  "Because having new software in Debian is good." - Josselin Mouette
"Because having good software in Debian is new." - Gabucino