[MPlayer-dev-eng] One demended feature to add

Filip Kalinski filon at pld.org.pl
Fri Feb 7 03:20:58 CET 2003


On Fri, 7 Feb 2003 02:00:12 +0100
Filip Kalinski <filon at pld.org.pl> wrote:

> On Fri, 7 Feb 2003 00:25:40 +0100
> Filip Kalinski <filon at pld.org.pl> wrote:
> 
> > Hi,
> > 
> > There were demands to make an ability to choose fsullscren switching type
> > from command line. I think, that it would be really useful to have it in 0.90
> > because with it many bugs in windowm nanagers can be solved by just
> > setting different fullscreen type prefrenerence.
> > 
> > I have already made a patch and tested it for some time and I think, that it
> > doesn't contain ay new bugs.
> > 
> > Are there any chances to include it in 0.90?
> > 
> > (I will do some tests with new metacity from gnome 2.2 and send it tommorow).
> > 
> 
> The patch is attached (works fine with new metacity).
> If there are no complains I will aplly it (and later documentation changes).
> 
> Changes:
> - support command line parameter -fstype, eg. -fstype layer:12,netwm:above
> - help (-fstype help) also availabible
> - support state BELOW (someone may want to use it...) and, by -fstype none forcing of
>   not chaning window layer (user request)
> - drop icelayer option, it can be set by -fstype layer:<number>
> - simplify vo_x11_fullscreen:
>   * change decoraions etc. also for STATE_FULLSCREEN (too much mess and
>     would be not really nice with new framework)
>   * don't check for wm type on each fullscreen change (it is stupid and will not work
>     properly in most cases)
> 
> And cleanup:
> - use mp_msg (with MSGT_V) instead of mp_dbg and printf later :-)
> - drop vo_wm_Unknow stupididty (use 0 instead)
> - and more...
> 

And now with fixed 2 x 10l and parisng vo_fstype_list only once (not
on every fullscreen state change).

-- 
Filip Kalinski <filon at pld.org.pl>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dev.main.diff
Type: application/octet-stream
Size: 17515 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20030207/809de319/attachment.obj>


More information about the MPlayer-dev-eng mailing list