[MPlayer-dev-eng] Fast Forward and Slow Motion Patch

[Jonas Jermann]

On Fri, Feb 07, 2003 at 02:57:04PM +0100, Struan Bartlett wrote:
> I previously sent this email to the mplayer-users' list, but that was 
> probably the wrong place.

You forgot to add [PATCH].

> I understand there's a feature-freeze going on, but is there any chance 
> this small but useful (and hopefully uncontroversial) patch could make 
> it into rc4?

I dout, but again: I don't know much about coding...

> >>>I tried a short hack to mplayer, to alter the 'playback_speed' 
> >>>setting while the movie is playing. It worked fine, except that 

[snip]

> Press ']' to speed up playback first x2, then x4, then x8, assuming your 
> video driver can handle the speed.

Hmm, why not specify the factor over mplayer's input system?

> You'll observe that audio is *not* 
> accelerated, because this is harder to do. I've left the audio switched 
> on, because it's more fun that way.

oho! I don't know much about coding, but that really looks
ugly. Btw: Did you test it? I tried to do something similar 
myself but it crashed because of the audio buffer size.

[...]

> I imagine another patch could easily mute the audio during fast forward 
> or slow motion.

I imagine it's not easy. Especially the A/V sync...

Anyway, I somehow didn't like your patch (sorry): Why add a new 
configure option? Why not add an upper limit, I'm not sure, but 
x16 speed is bad IMHO. Why not add an upper limit? a=a*2 is 
better written as a*=2 (IMHO), especially for long "a" as in 
your patch. And I'm still not sure if playback speed is the 
right approach. Why not just skip frames instead of raising 
speed? It doesn't waste performance and works longer (ok, it 
needs keyframes).

Best Regards
    Jonas