[MPlayer-dev-eng] Re: [PATCH] dvd2divxscript.pl overhaul

[Dirk Meyer]

Michael Halcrow wrote:
> There is still work to be done on this, but I wanted to get your opinion
> before I go off the deep end.

OK, here it goes. First of all: nice script. If I put something called
movie.vob in the directory, it even encodes that instead of a dvd. Now
some comments:

Bugs:

- I don't have write access to /dev/tty8. It should be possible to
  change one variable to set the debug output file/device

- the crop* files aren't removed at the end. A second movie will be
  encoded with the same values and maybe they are wrong


Enhancement ideas:

- use mplayer -vo null -ao null to cropdetect. With that I don't need
  X or whatever to get the values

- if no ofps is given, ask mplayer for the fps of the movie and take
  this one. It's better than giving the value on the command line

- support audio copy to support avis with AC3 sound

- support more than one target disc (you will need that for AC3). Or
  is this working now, I haven't found it in the code.


Dirk
-- 
A black cat crossing your path signifies that the animal is going somewhere.
                -- Groucho Marx