[MPlayer-dev-eng] packaging cygwin mplayer

Joey Parrish joey at nicewarrior.org
Mon Feb 10 17:35:24 CET 2003


On Mon, Feb 10, 2003 at 10:20:26AM -0600, Joey Parrish wrote:
> On Mon, Feb 10, 2003 at 04:52:12PM +0100, Diego Biurrun wrote:
> > > > send the patch, i or alex will check it
> > > It's only needed when packaging MPlayer outside of a complete cygwin
> > > system.  I'll try to make as much CVS-worthy patch as I can, but this is
> > > mostly hacks that have no place in CVS.
> > 
> > Umm, perhaps you don't realize this, but nobody has working real DLLs under
> > Cygwin except you ...  So what do you mean by "only needed when packaging
> > MPlayer outside of a complete Cygwin environment"?
> 
> Really?  I had no idea.  Well, the audio is still broken, but here are
> the patches I'm using.  The *_clean.patch are the clean parts that I
> think you might find useful under normal cygwin environments, and the
> *_hack_cumulative.patch are the parts that I apply for packaging on top
> of the clean patches.
> 
> These are based on my old (hacked) patches.  I just finished remaking
> them, but I haven't tested these yet.  They should be the same, but
> since it takes over half an hour to recompile on this cygwin box I'm
> going on faith.  :)  If they blow up my computer in the next hour, I'll
> post again and say "oops."
> 
> Also, I need to verify that these patches don't break anything under
> linux.  That might have to wait, because I have to go to school soon.
> It might be later tonight (American night) before I get a chance to put
> in more serious work.

AHA!  I caught an error, here's a cumulative patch.  I was missing two
includes and a curly brace in ad_realaud.c.  And _now_ I'm off to class.
:)

--Joey
-------------- next part --------------
--- ad_realaud.c	Mon Feb 10 10:32:28 2003
+++ ad_realaud.c.fixed	Mon Feb 10 10:32:02 2003
@@ -10,6 +10,9 @@
 #include <stddef.h>
 #include <dlfcn.h>
 
+#include "mp_msg.h"
+#include "help_mp.h"
+
 #include "ad_internal.h"
 
 static ad_info_t info =  {
@@ -254,7 +257,7 @@
   }
 
 #ifdef USE_WIN32DLL
-  if (dll_type == 1)
+  if (dll_type == 1) {
     if(wraSetPwd){
 	// used by 'SIPR'
 	wraSetPwd(sh->context,"Ardubancel Quazanga"); // set password... lol.


More information about the MPlayer-dev-eng mailing list