[MPlayer-dev-eng] [PATCH] real demuxer fix V3

[Arpi]

Hi,

> > then it's simplified to if((x&(~0x1F))==0x40)
> > it matches both 0x4? and 0x5?
> >
> :)
> well you managed to simplify it. but what happens if 
> 1) rv50 uses 0x50-57 as B frame ? (could be the current situation, but 
> probably not)

if( ( (fourcc='RV30') && (!(x&0x10)||!(x&0x08)) ) ||
    ( (fourcc='RV40') && ((x&0x1F)==0x40) ||
    ( (fourcc='RV50') && ((x&0x07)==0x50) ||
   ...
){
   ...
}

> 2) I want to read and understand the code next week

it's more readable than your half-page long if() was

> anyhow i guess it's a matter of taste

agree


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu
    "However, many people beg for its inclusion in Debian. Why?" - Gabucino
  "Because having new software in Debian is good." - Josselin Mouette
"Because having good software in Debian is new." - Gabucino