[MPlayer-dev-eng] [PATCH] real demuxer fix V3

Balatoni Denes pnis at coder.hu
Wed Feb 12 23:38:52 CET 2003


Hi again!
> > for rv30 x<0x18 is even better
> > (let x be unsigned)
>
> no
> maybe ((x&0x1F)<0x18) ?
I don't think I saw rv30 files with B frames with 0x3? in s[0],
only 0? and 1?
but there could be such files (those rv40 files are not such files either 
iirc)

> > eh we have been spending about 1 and a half hours with this important
> > issue
>
> yes, it's very important
>
> > feel free to change it to whatever you like, or reject it ;)
>
> i just want it to be done well
alright, imho it is easier to extend/understand the way I wrote it
it is imho also nice - provided that rv90 will be somewhat compatible
with this - to not check for fourcc, so some mutant files can be played too 
(if there are any, they can be made of course).
and most of all, I am not so sure whether all the numbers are correct,
so I wouldn't want to optimize it into a 3 chars long expression, as it might 
have to be changed soon anyway

ah  ((x&0x1F)<0x18 is not correct now I realize
as eg. 7? is I/P

ah yes I might be paranoid, but after every change I tried to check all files
and I am getting a bit bored of this ;) probably that's a reason why I just 
want it to stay as it is - or others change anything they want, but not me 
for now

bye
Denes








More information about the MPlayer-dev-eng mailing list