[MPlayer-dev-eng] Re: [PATCH] Repairing breakage to RTP streaming

[Arpi]

Hi,

> Oops - you were right after all.  (I should never have doubted you :-)
:)

>  
> +    if (demuxer == NULL || demuxer->stream == NULL) break;  // shouldn't
> happen
> +    demuxer->stream->eof = 0; // just in case 
> +

could you explain this?
it's ok to apply since it's in yoru file but i can't see teh reason of
demuxer==null or demuxer->stream == NULL to happen, unless there is
a serious bug somewhere else, but then that bug should be fixed.
mayeb add an abort() instead of break; so we can catch and backtrace teh
bug...

>    break;
>   }
> -#ifdef STREAMING_LIVE_DOT_COM
> - case DEMUXER_TYPE_RTP:
> -   // If the RTP stream is a MPEG stream, then we use this code to check
> -   // for MPEG headers:
> -   if (!demux_is_mpeg_rtp_stream(d_video->demuxer)) break;
> -   // otherwise fall through to...
> -#endif
>   case DEMUXER_TYPE_MPEG4_ES: {
>     videobuf_len=0; videobuf_code_len=0;
>     mp_msg(MSGT_DECVIDEO,MSGL_V,"Searching for Video Object Start code...
> ");fflush(stdout);
> @@ -129,6 +122,13 @@
>     sh_video->format=0x10000004;
>     break;
>   }
> +#ifdef STREAMING_LIVE_DOT_COM
> + case DEMUXER_TYPE_RTP:
> +   // If the RTP stream is a MPEG stream, then we use this code to check
> +   // for MPEG headers:
> +   if (!demux_is_mpeg_rtp_stream(d_video->demuxer)) break;
> +   // otherwise fall through to...
> +#endif
>   case DEMUXER_TYPE_PVA:
>   case DEMUXER_TYPE_MPEG_ES:
>   case DEMUXER_TYPE_MPEG_PS: {
> 

this part looks ok, i'll apply to the 0_90 tree


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu
    "However, many people beg for its inclusion in Debian. Why?" - Gabucino
  "Because having new software in Debian is good." - Josselin Mouette
"Because having good software in Debian is new." - Gabucino