[MPlayer-dev-eng] Re: [PATCH] Repairing breakage to RTP streaming

[Ross Finlayson]

> > +    if (demuxer == NULL || demuxer->stream == NULL) break;  // shouldn't
> > happen
> > +    demuxer->stream->eof = 0; // just in case
> > +
>
>could you explain this?
>it's ok to apply since it's in yoru file but i can't see teh reason of
>demuxer==null or demuxer->stream == NULL to happen, unless there is
>a serious bug somewhere else, but then that bug should be fixed.

Arpi,

The
         if (demuxer == NULL || demuxer->stream == NULL) break;
line was just conservatism on my part. You're correct that it should never 
happen, so you can omit that line if you wish.

However, the following line
         demuxer->stream->eof = 0; // just in case
is important, because I found that streaming using a SDP file (i.e., using 
"-sdp") stopped working otherwise.  (Somehow "eof" got initialized as 1 in 
this case.)

         Ross.