[MPlayer-dev-eng] [PATCH] mga_vid possible buffer overflow (and kernel oops?) fix

[D Richard Felker III]

On Sat, Feb 15, 2003 at 05:33:50PM +0100, Diego Biurrun wrote:
> Diego Biurrun writes:
>  > Attila Kinali writes:
>  >  > On Thu, 13 Feb 2003 10:32:32 +0100
>  >  > Dariusz Pietrzak <eyck at nowanet.lub.pl> wrote:
>  >  > 
>  >  > > > > Let's see how long it takes for us to accept/reject it ;-)
>  >  > > > It looks fine for me. Could be applyed
>  >  > > I applied it, since the bug was in my code.
>  >  > >  ( or should we wait for few more mails stating that the fix is ok? )
>  >  > 
>  >  > As nobody complained (AFAIK Arpi is the last one who knows the mga_vid code
>  >  > who didn't tell his opinion) it's IMHO ok to apply it.
>  > 
>  > Well, apply it then.
> 
> Just remembered that it was applied, however, none of the sprintf
> calls were replaced by snprintf.  Wasn't sNprintf the point of the
> whole patch?

The patch was nonsense anyway. There was no possibility of overflow
because the only things printed were short strings and numbers (which
have limited length), no user-supplied strings.

Rich