[MPlayer-dev-eng] Re: install localized manpages + [PATCH#3.14159265]

[Andreas Hess]

On Mon, Feb 17, 2003 at 06:47:23PM +0200, Andriy N. Gritsenko wrote:
> Sometime (on Monday, February 17 at 18:28) I've received something...
> >On Mon, Feb 17, 2003 at 01:11:05PM +0200, Andriy N. Gritsenko wrote:
> >> +# set up LANGUAGES
> >> +test "$LINGUAS" || LINGUAS = `cd DOCS;/bin/ls -d ?? ??_??`
> >> +LANGUAGES=`echo $LINGUAS | sed 's/en//g' | sed 's/^ *//'`
> 
> >This sucks, too. Everyone who has no $LINGUAS environment variable
> >will get all manpages.
> 
>     As I said before if you don't want all manpages be installed then
> just run something like that:
> 
> LINGUAS="" ./configure .....

But why? Other programs don't force me to unset a never set $LINGUAS
environment variable. So why not default to LINGUAS=""?

> >>  LANG = C
> >>  LINGUAS = $LINGUAS
> >> +LANGUAGES = $LANGUAGES
> 
> >And it adds unneeded bloat to the Makefile.
> 
> You can see any other way to define which manpages have to be installed?

Yes, $LINGUAS isn't needed in config.mak .


Patch attached.
-------------- next part --------------
Index: configure
===================================================================
RCS file: /cvsroot/mplayer/main/configure,v
retrieving revision 1.664
diff -u -r1.664 configure
--- configure	17 Feb 2003 13:06:03 -0000	1.664
+++ configure	17 Feb 2003 18:19:38 -0000
@@ -294,7 +294,6 @@
 
 
 # set up LANGUAGES
-test "$LINGUAS" || LINGUAS=`cd DOCS;/bin/ls -d ??` 2>/dev/null
 LANGUAGES=`echo $LINGUAS | sed 's/en//g' | sed 's/^ *//'`
 
 # 1st pass checking for vital options
@@ -4811,7 +4810,6 @@
 # -------- Generated by configure -----------
 
 LANG = C
-LINGUAS = $LINGUAS
 LANGUAGES = $LANGUAGES
 TARGET_OS = $system_name
 DESTDIR =