[MPlayer-dev-eng] -geometry code and -vo fbdev broken

[Attila Kinali]

On Sun, 23 Feb 2003 15:42:00 +0100
Attila Kinali <kinali at gmx.net> wrote:


> -geometry doesnt really do what it should noone
> of the -vo drivers using it does use the full power.
> After spending some hours of trying to find a simple patch
> to solve that i think that it should be rewriten from scratch
> and documented (or can someone explain me the meanings of the
> parameters of geometryFull() ?)
> Until then i suggest that -geometry is removed from 0_90.


Ok, it wasnt really a rewrite, but a clean up.
The patch disables -geometry for all but xv 
(i dont understand their code atm and dont want to spend
too much time if this isnt ok)
I also removed the call from mplayer.c's main()
(why was it there in the first place ?)

geometry() now uses only the 6 parameters that made
sense to me (all are mandantory) and returns
x,y,w,h if -geometry is used.

Any comments on this ?
If it's ok i'll commit it.

			Attila Kinali
-- 
Emacs ist für mich kein Editor. Für mich ist das genau das gleiche, als wenn
ich nach einem Fahrrad (für die Sonntagbrötchen) frage und einen pangalaktischen
Raumkreuzer mit 10 km Gesamtlänge bekomme. Ich weiß nicht, was ich damit soll.
		-- Frank Klemm, de.comp.os.unix.discussion
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: koth-geometry-2003-02-23.patch
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20030223/172dbe0e/attachment.txt>