[MPlayer-dev-eng] [PATCH] i18n fix for NetBSD

[D Richard Felker III]

On Sun, Feb 23, 2003 at 10:39:31PM -0600, Frederick Bruckman wrote:
> Hi,
> 
> NetBSD's bindtextdomain() clone is evidently deficient. It never
> returns the second, dirname argument, but only the first on success
> or NULL on any failure. Furthermore, it doesn't do anything different
> if the second argument is NULL, so the call intended to query the
> directory for the default domain was SEGV'ing.
> 
> For mplayer, I wrote a configure test (rather than use __NetBSD__),
> with the idea that NetBSD might get this fixed eventually.
> 
> Note that it's not safe to use the return value of bindtextdomain()
> in printf(), if it might be NULL. Does GNU's never return NULL?

Passing NULL to printf is safe in all implementations I've seen, but
I'm not sure the standard requires this. Any comments?

Rich