[MPlayer-dev-eng] Re: latest version of translated manpage installation

[Andriy N. Gritsenko]

    Hi, Andreas Hess!

Sometime (on Friday, February 21 at  0:55) I've received something...
>-	$(INSTALL) -c -m 644 DOCS/en/mplayer.1 $(MANDIR)/man1/mplayer.1
>-	@if [ -n "$(LANGUAGES)" ]; then \
>-	    for i in $(LANGUAGES); do \
>-		if [ -f DOCS/$$i/mplayer.1 ]; then \
>-		    echo "Installing manual for language $$i" ; \
>-		    mkdir -p $(MANDIR)/$$i/man1 ; \
>-		    $(INSTALL) -c -m 644 DOCS/$$i/mplayer.1 $(MANDIR)/$$i/man1/mplayer.1 ; \
>+	for i in $(LANGUAGES); do \
>+		if test "$$i" = en ; then \
>+			$(INSTALL) -c -m 644 DOCS/en/mplayer.1 $(MANDIR)/man1/mplayer.1 ; \
>+		else \
>+			mkdir -p $(MANDIR)/$$i/man1 ; \
>+			$(INSTALL) -c -m 644 DOCS/$$i/mplayer.1 $(MANDIR)/$$i/man1/mplayer.1 ; \
> 		fi ; \
>-	    done ; \
>-	fi
>+	done
> ifeq ($(MENCODER),yes)
> 	$(INSTALL) -m 755 $(INSTALLSTRIP) $(PRG_MENCODER) $(BINDIR)/$(PRG_MENCODER)
>-	ln -sf mplayer.1 $(MANDIR)/man1/mencoder.1
>-	@if [ -n "$(LANGUAGES)" ]; then \
>-	    for i in $(LANGUAGES); do \
>-		if [ -f DOCS/$$i/mplayer.1 ]; then \
>-		    ln -sf mplayer.1 $(MANDIR)/$$i/man1/mencoder.1 ; \
>+	for i in $(LANGUAGES); do \
>+		if test "$$i" = en ; then \
>+			ln -sf mplayer.1 $(MANDIR)/man1/mencoder.1 ; \
>+		else \
>+			ln -sf mplayer.1 $(MANDIR)/$$i/man1/mencoder.1 ; \

    You are wrong in that part. LINGUAS may point _only_ to additional
languages. For example, I have LINGUAS="uk ru" so I'll never get english
manpage at all if there is ukrainian or russian manpage but it's wrong.
Any other package always install english (as default) localization but
your patch skipped that. Fix it, please, back as I did it.

    With best wishes.
    Andriy.