[MPlayer-dev-eng] Re: [patch] improve dxr3 tv norm switching

[David Holm]

Why do you add so many #ifdefs? They are only needed if you have to check for
some mplayer feature to be enabled (such as X11) or to be compatible with an
older version of em8300 (like 0.12.0). All these new ifdefs just waste space
and makes no sense.
Why did you remove all the '.' from the output? A sentence is generally
started by a capitalized letter and ended with a '.'.
Why did you remove the initialization values to some of the declared
variables? I personally don't like having uninitialized variables floating
around.

I have commited the code that resets the tv norm. I also removed some of the
senseless ifdefs from the previous norm patch.
Most of the textual changes don't make sense to me, why remove the trailing
'.'?

//David Holm

On Thursday 02 January 2003 19:12, Thomas Jarosch wrote:
> > The merged patch is suboptimal (for me, at least) to what I had in my
> > tree, so I'll try and merge the two. The most important bit is that tv
> > norm is not being restored when mplayer quits.
>
> Just tested, patch works fine.
>
> > BTW, vo_dxr3 could do with a bit of ifdef cleaning, it's quite nasty...
>
> After I've spotted some typos I decided to clean up
> the commandline output of vo_dxr3.
>
> Though the point about ifdef cleaning is true...
>
> David: Is there any need for all these ifdefs in vo_dxr3.c anymore?
>
> Arpi, attached you'll find my cleanup patch either as complete patch
> including Jens Axboe's one or as standalone patch.
>
> Cheers,
> Thomas