[MPlayer-dev-eng] [PATCH] TV & DXR3: mencoder works but mplayer does not

[Jindrich Makovicka]

Jaroslav Tulach wrote:

> Sorry if this message comes twice.
>
>
> Hi,
> few days ago I have cried on user mailing list that I can record from a
> TV card with sound, but I cannot hear the sound during playback, I have
> just investigated the problem and here is a patch to make everything
> work. I'll be graceful if you could review it, improve it and 
> integrate it.

Unfortunately, it doesn't work well with anything else than ao_SDL.

> Problem description:
>
> mencoder -tv
> on:driver=v4l:device=/dev/video0:width=384:height=288:forceaudio:forcechan=2:adevice=/dev/dsp
> -ovc lavc -lavcopts vcodec=mpeg4:vbitrate=900 -oac mp3lame -lameopts
> cbr:br=32 -o Y.avi
>
> works fine, but
>
> mplayer -vo dxr3:noprebuf -ao oss:/dev/em8300_ma -tv
> on:driver=v4l:device=/dev/video0:width=384:height=288:forceaudio:forcechan=2:adevice=/dev/dsp
>
> does not. The reason for this is that mplayer.c sets tv_param_immediate
> = 1 and then the tv_v4l.c driver disables the sound completely.

Yes I know that. I disabled it completely because i didn't know how to 
solve the sync problems. (and it wasn't necessary for me as I use an 
external loopback => no motivation for spending time).

> Solution:

...

> I am looking forward to see conflict during cvs upd indicating that my
> patch was integrated ;-)
> -jst 

No, I won't commit this in the current form.

> PS: In tvi_v4l.c there is a code:
>
> case TVI_CONTROL_IS_AUDIO:
>     if (priv->channels[priv->act_channel].flags & VIDEO_VC_AUDIO)
>     {
>         return(TVI_CONTROL_TRUE);
>     }
>     return(TVI_CONTROL_TRUE);
>
> which I think has wrong last line. It should be return FALSE, is it not?

Thanks, I'll review it.

Regards,

-- 
Jindrich Makovicka