[MPlayer-dev-eng] [PATCH] Installing docs/manpage during make

[Arpi]

Hi,

> El sáb, 04 de ene de 2003, a las 05:55:08 +0100, sr dijo:
> > Updated the patch so it can be applied to current cvs and did some further fixes.
> That one was broken because I used an also broken patch to apply original changes. 
> Anyways, here's a fixed, double-checked one :)
> 
> One question though: shouldn't the manpages be gzipped? something like 'gzip -9c mplayer.1 > mplayer.1.gz' during make install.
> 
> I hope you'll finally apply the patch now :)

maybe if you coudl tell what the patch does...

>  if x86 ; then
> @@ -1558,7 +1567,6 @@
>  fi
>  echores "$_i18n"
>  
> -
>  # Checking for setlocale() ...
>  # CSAK EGY MARADHAT - A HEGYLAKO
>  # Nemnem. a TV Maci !
> @@ -1578,7 +1586,6 @@
>  fi
>  echores "$_setlocale"
>  
> -
>  echocheck "language"
>  test -z "$LINGUAS" && LINGUAS="en"
>  if test -f "help/help_mp-${LINGUAS}.h" ; then

please avoid useless cosmetics

> @@ -1590,6 +1597,45 @@
>  _mp_help="help/help_mp-${LINGUAS}.h"
>  test -f $_mp_help || die "$_mp_help not found"
>  
> +echocheck "html docs"
> +test -z "$DOCS_INSTALL" && DOCS_INSTALL=$DOCS_LANGUAGES_DEFAULT
> +if test "`echo $DOCS_INSTALL | grep zh_CN`" ; then
> + _install_docs_cn=yes
> +else
> + _install_docs_cn=no
> +fi
> +if test "`echo $DOCS_INSTALL | grep en`" ; then
> + _install_docs_en=yes
> +else
> + _install_docs_en=no
> +fi
> +if test "`echo $DOCS_INSTALL | grep de`" ; then
> + _install_docs_de=yes
> +else
> + _install_docs_de=no
> +fi
> +if test "`echo $DOCS_INSTALL | grep fr`" ; then
> + _install_docs_fr=yes
> +else
> + _install_docs_rf=no
> +fi
> +if test "`echo $DOCS_INSTALL | grep hu`" ; then
> + _install_docs_hu=yes
> +else
> + _install_docs_hu=no
> +fi
> +if test "`echo $DOCS_INSTALL | grep it`" ; then
> + _install_docs_it=yes
> +else
> + _install_docs_it=no
> +fi
> +if test "`echo $DOCS_INSTALL | grep pl`" ; then
> + _install_docs_pl=yes
> +else
> + _install_docs_pl=no
> +fi
> +echores "using ${DOCS_INSTALL}"
> +

WTF is this?
why don't you parse out the list, instead of adding 5 lines per language
here and half page per language in makefile?

there must be a more elegant/shorter/optimal/cleverer solution.


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu