[MPlayer-dev-eng] [PATCH] gif demux & decode support
Arpi
arpi at thot.banki.hu
Wed Jan 8 13:16:44 CET 2003
Hi,
> > A'rpi / Astral & ESP-team
>
> Okay, new patch attached. This one has variable fps support,
> documentation for the new demuxer/decoder, and demux_open is fixed.
this is still a very ugly and unacceptable hack :(
there is no video decoding in your vd_gif.c at all, it just does rgb8->rgb24
conversion. why don't you export rgb 8 raw frames from the demuxer then?
> + GifFileType *gif = (GifFileType *)sh->ds->demuxer->priv;
this is unacceptable.
you should append the extra data (like palette) to the sh_video->bih[],
see vd_raw.c for example.
imho vd_raw.c could handle your rgb8 raw images, no need to add duplicate of
it named vd_gif.c
A'rpi / Astral & ESP-team
--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu
More information about the MPlayer-dev-eng
mailing list