[MPlayer-dev-eng] [PATCH] Compiler warnings almost gone :)

Alex Beregszaszi alex at naxine.org
Fri Jan 10 10:31:33 CET 2003


Hi,

> After the last few patches I'm almost done with eliminating compiler
> warnings. :) Only a few worth mentioning remain. Two, in particular,
> are probably easy to fix by the maintainers:
> 
> pl_format.c:231: warning: suggest parentheses around + or - inside
> shift vo_dga.c:580: warning: suggest parentheses around && within ||
> 
> Is the attached patch a good fix?

The vo_dga fix should be trivial, but the pl_format not.
I think it should be (1<<31)-1 instead your version ( (1<<(31-1)) ).
Anyway, do not commit it wihtout Anders answer.

-- 
Alex Beregszaszi  <alex at naxine.org>
(MPlayer Core Developer -- http://www.mplayerhq.hu/)


More information about the MPlayer-dev-eng mailing list