[MPlayer-dev-eng] [PATCH] Compiler warnings almost gone :)
Anders Johansson
ajh at watri.uwa.edu.au
Sun Jan 12 07:02:08 CET 2003
> Hi,
>
> > After the last few patches I'm almost done with eliminating compiler
> > warnings. :) Only a few worth mentioning remain. Two, in particular,
> > are probably easy to fix by the maintainers:
> >
> > pl_format.c:231: warning: suggest parentheses around + or - inside
> > shift vo_dga.c:580: warning: suggest parentheses around && within ||
> >
> > Is the attached patch a good fix?
>
> The vo_dga fix should be trivial, but the pl_format not.
> I think it should be (1<<31)-1 instead your version ( (1<<(31-1)) ).
> Anyway, do not commit it wihtout Anders answer.
>
It is a bug, but remove the file it is obsolete.
//Anders
More information about the MPlayer-dev-eng
mailing list