[MPlayer-dev-eng] af layer STILL broken

[Anders Johansson]

Hi,

Sorry the patch brakes the decoding I get sig 11 in ad_libvorbis when
using the patch (second tome decode_audio() is called). I found one
bug which I fixed. I can't reproduce completely since I am running a
alsa9 only system at the moment (statically linked kernel without
oss emulation). I'll try it again when I get home. My guess is that ao_oss
reports that it supports float even though it doesn't. alsa works qite
well and detects the float, it doesn't support it however and returns
uint8, which is correct but not good, and will need fixing.

Also the patch didn't apply cleanly.

//Anders

> Something is totally wrong in the af layer still. I just tried
> modifying ad_libvorbis.c with the attached patch to output float
> instead of converting to int, so that fast float->int could be done in
> the filter layer once it's implemented. However, even if I use -format
> or explicitly load a filter chain to convert to s16le, mplayer STILL
> tries to configure the AO device for float, and outputs garbage!! This
> really needs to be fixed for 0.90 IMO. Should be easy to reproduce; if
> not I'll send you my exact command line and stuff.
> 
> Rich
>