[MPlayer-dev-eng] [PATCH]Fix subcp crash(hopefully)

[Salvador Eduardo Tropea]

陆然 wrote:

>Hi,
>
>On Tuesday 14 January 2003 17:40, Arpi wrote:
>  
>
>>Hi,
>>
>>    
>>
>>>I think the bug is this, I test mplayer with a Chinese subtitle in ssa
>>>format, since Chinese charactor use two byte to store one char, maybe
>>>half of the Chinese char looks like '{', then it will be eliminated. the
>>>other half char remain in subtitle cause iconv crashed. So I change the
>>>code to eliminate
>>>      
>>>
>>hmm. what about doing { } removal _after_ the iconv conversion?
>>
>>in packed charsets like UTF8 any random char may be there...
>>    
>>
>
>I'm afraid then ssa should be handled separately. In other format {} should 
>not be removed, maybe they are part of the subtitles.
>
Then we could do the iconv convertion to a temporal buffer and do the 
remove.
This is need by other formats also.

> Maybe the better way is 
>to add more test point before remove anything from subtitle. But I don't have 
>a ssa sub with {}, so I don't know what kind of info can be used to test it.
>
>  
>
Here are some examples, but you can hit similar things randomly.
Dialogue: Marked=0,0:52:43.21,0:52:45.84,1 MENOS DE 
SOMBRA,NTP,0000,0000,0000,,{\fs36}El nombre de ese muchacho es...
Dialogue: 
Marked=0,0:52:46.84,0:52:48.84,FANSUB,NTP,0000,0000,0000,,SUBTITULADO 
POR {\fnOrient\c&HFFFFFF&}ISAGARA FANSUB

I don´t have the reference but \fs seems to be "Font Size", \fn "Font 
Name" and \c&....& "Color".

SET

-- 
Salvador Eduardo Tropea (SET). (Electronics Engineer)
Visit my home page: http://welcome.to/SetSoft or
http://www.geocities.com/SiliconValley/Vista/6552/
Alternative e-mail: set at computer.org set at ieee.org 
Address: Curapaligue 2124, Caseros, 3 de Febrero
Buenos Aires, (1678), ARGENTINA Phone: +(5411) 4759 0013