[MPlayer-dev-eng] [PATCH] fix explicitly setting CPU options in configure + cosmetics

Diego Biurrun diego at biurrun.de
Sun Jan 19 18:57:07 CET 2003


Resending.  Last time around I only got a comment from Alex who
pointed out a bug in the cosmetics part.  It's fixed now.

Hello Team!

I noticed some time ago that configure ignores CPU option settings
from the command line, like --disable-mmx or --disable-mtrr.  The
problem is that CPU feature detection etc happens before the main
command line argument parsing.  My patch adds a small CPU option
command line parsing snippet in front of the CPU section, making those
options produce the desired effect.

A nicer solution would probably be just moving all of the command line
parsing to the beginning of configure, but that requires more invasive
changes.  If you wish I might have a go at that, but in the meantime
my patch should be sufficient.

OK to commit?

While staring at the configure script for some time I could not help
noticing and fixing a few typos etc here and there - you should know
me by now ;).  I put these (cosmetic) changes into a separate patch -
OK to commit?

Diego


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: cpuoptions-main.patch
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20030119/6cb8b55f/attachment.asc>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: cpuoptions-cosmetics.patch
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20030119/6cb8b55f/attachment.txt>


More information about the MPlayer-dev-eng mailing list