[MPlayer-dev-eng] [PATCH] fix explicitly setting CPU options in configure + cosmetics

Alvaro Lopes alvieboy at alvie.com
Tue Jan 21 13:43:12 CET 2003


Diego Biurrun wrote:

>Arpi told me on IRC he has mixed feelings about this patch - there has
>to be somebody else who can comment on this patch..  Please somebody
>speak up!
>
>Diego
>
>Diego Biurrun writes:
> > Resending.  Last time around I only got a comment from Alex who
> > pointed out a bug in the cosmetics part.  It's fixed now.
> > 
> > Hello Team!
> > 
> > I noticed some time ago that configure ignores CPU option settings
> > from the command line, like --disable-mmx or --disable-mtrr.  The
> > problem is that CPU feature detection etc happens before the main
> > command line argument parsing. 
>
These are two separate things, IMO. One is compile-time CPU options 
(which then should propagate through code via preprocessing directives), 
and other is run-time CPU options.

Compile-time options perhaps only make sense if we're enabling/disabling 
asm routines and/or gcc achitecture dependant flags. If we can build 
binaries with MMX support that will work on 386, the better.

So, I see no utility for this, unless as stated.

-- 

Álvaro Lopes 
---------------------
A .sig is just a .sig




More information about the MPlayer-dev-eng mailing list