[MPlayer-dev-eng] [PATCH] gui crash for second audio file

Arpi arpi at thot.banki.hu
Sun Jan 26 18:59:40 CET 2003


Hi,

> this patch fixes a crash i get when opening two mp3's in a row in the 
> gui.

i cannot reproduce :(

> -  if(osd_level>=1){
> +  if(osd_level>=1 && sh_video){

anyway this is not the right, fix, there are many references to sh_video in
OSD related code, so we've added a geenral 'disable OSD for audio-only
files' workaround long time ago:

// If there is no video OSD has to be disabled.
// In case of playing a playtree we have to restore the
// old OSD level after playing one or more audio-only files.
if(!sh_video && osd_level > 0) { // save OSD level only once
    osd_level_saved = osd_level;
    osd_level = 0;
} else if (osd_level_saved > -1) { // if there is a saved OSD level, restore
it
    osd_level = osd_level_saved;
    osd_level_saved = -1;
}

i can imagine that you changed OSD level or sth in Gui preferences and it
override this (changed osd_level back from 0).


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu


More information about the MPlayer-dev-eng mailing list