[MPlayer-dev-eng] [BUG] concerning reference-files (was: [PATCH]

[Arpi]

Hi,

> > > ftp/MPlayer/samples/V-codecs/QTRLE/Hole_Dollparts_MSTR.mov
> > > ftp/MPlayer/samples/V-codecs/QTRLE/Jag-finder-renaming.mov
> >
> > [...]
> > Jag... looks ok (i'll compare with qt as soon as i boot win), the other
> > one is detected as a reference file and does nothing.

> > MOV: Reference Media file!!!

> > MOV: Movie DATA found!

> It has references AND Movie Data! What should be done ?

ignore movie data.
at least qt spec says (suggests) that file type can be one of these:
- movie media
- reference media
- vrml media
- sprite animation media
- etc.

not a mix of these.

> As the demuxer->video-buffer is already initialised and sued by the 
> reference-playlist it would be wise to use it that way, then line 

maybe it worth to check if it's really a referenec media, ie it has at least
one URL/references or zero one. I remember seeing some sprite animation file
containing reference headers but zero URLs in the header part.

> 450 should be changed from:
> 
> -if (flags==5) // reference & header sent
> -        return 1;

forget this mess.

the current 'design' (hack) doesn't allow a file being reference &
movie file at the same time.

> This should be done also, if a playlist was detected (flag|=4 set), but with 
> the difference that flag 4 set means:

do not overcomplicate things.
parse header. if there are reference tracks, parse them and change demuxer
type to playlist.
if it has sprite animation track(s), then parse them.

> However all solutions I could think of very much complicate the code and I 
> disliked them, so I wait for a helping hand from heaven or Arpi ;-)

but we shouldn't commit such complicated thing before 0.90.
so it's either a trivial simple patch or delay it.

> PS: Sorry, for this Bug, I remember well that we talked about silly files 
> having REF- and -MDAT-section and then in the end I forgot about it :-(
huh?
mdat in ref file is ok (mdat can contain any kind of data, even for
references), but audio/video tracks in reference files is illegal, imho.

> > Warning empty playlist


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu
    "However, many people beg for its inclusion in Debian. Why?" - Gabucino
  "Because having new software in Debian is good." - Josselin Mouette
"Because having good software in Debian is new." - Gabucino