[MPlayer-dev-eng] [PATCH] GIF support, release quality?

[Arpi]

Hi,

> > On Tue, Jan 28, 2003 at 01:48:38AM +0100, Arpi wrote:
> > > the third one is very bad, the right way of auto-adding 'palette' is the
> > > one done for 'scale' and 'lavc' in vc.d
> > I'll look at it again and see what I can do different.
> I've looked it over, and I disagree about this.  Auto-adding scale
> and lavc are due to colorspace mismatches.  If your vo supports
> BGR8, then this will never happen.  There needs to be either some
> way of the codec notifying the rest of mplayer that there is a palette
> by setting a flag, or paletted colorspaces need to be different from
> standard BGR8.  Otherwise, I see no way to detect the existance of a
> palette and know when to auto-load vf_palette.  Another solution could

Ah. Yuo misunderstood the purpose of vf_palette. ok it's a bad name.
it's actually an BGR8->BGRx colorspace converter. If tehre is a palette, it
will be used, if no palette then grayscale is assumed.
So it bevaes the same way as scale or lavc or other csp converters.

> be to stop appending the palette to BIH and make a place for it.  A new
it would break AVI files wiht raw palette included in BIH.

> field could be checked for a NULL pointer to find the palette, but
> appending the palette to BIH leaves no way to know if it's there.
> The current way of handling palettes feels like a hack to me.
yes it is.

> > > btw it doesn't work ok for me, colors are wrong.
> > > try this one: http://www.distrowatch.com/images/banners/uhu.gif
> > Thanks, I'll see if I can figure out the problem.
> With latest unpatched CVS the colors of uhu.gif work fine with
> vf_palette.  I cannot reproduce.  Maybe your vo has issues?
I tried -vo x11 and -vo xv. Both bad. Btw teh colors are random,
if recompiled with different options, it gave different colors :)
so it looks like some uninitialized paletet array somewhere.
Also i got random sig11 in demux_close().


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu
    "However, many people beg for its inclusion in Debian. Why?" - Gabucino
  "Because having new software in Debian is good." - Josselin Mouette
"Because having good software in Debian is new." - Gabucino