[MPlayer-dev-eng] [PATCH] GIF support, release quality?

[Joey Parrish]

On Wed, Jan 29, 2003 at 11:09:02PM +0100, Arpi wrote:
> > Yes, except that the format is still BGR8.  lavc and scale can be loaded
> why?

Because paletted BGR8 still uses IMGFMT_BGR8.
When vo sees BGR8, it assumes it's not indexed, but packed 1 byte ber pixel.
This is not always true.

> > based on requested format or format incompatibilities.  How should
> > mpcodecs_config_vo() be notified of the need to load vf_palette?
> > vf_palette checks for a palette by checking for the number of planes in
> > the mpi it gets, but mpi has not been built when mpcodecs_config_vo() is

> it has NOTHING with the palette or number of colors.
> if the colorspace is BGR8 and the filter chain/vo driver doesn't accept BGR8
> then you have to instert vf_palette. easy.

I'm sorry, but you are wrong about this.
If the vo supports BGR8, but your video is BGR8 w/ palette, then you
will see garbage on the screen without vf_palette.  There is not a
single vo available that takes note of a palette in plane 1.

> because if the vo accepts BGR8, then inserting vf_palette is worse than
> nothing.

No, if vo accepts BGR8 and ignores the palette, you see garbage.

So that leads me to believe that we must either
1) add a decoder flag to ask for vf_palette to be loaded
  OR
2) make all vo's supporting BGR8 take notice of palette
  OR
3) make user who isn't aware of vf_palette wonder why he sees garbage

--Joey