[MPlayer-dev-eng] [PATCH] GIF support, release quality?

[Michael Niedermayer]

Hi

On Wednesday 29 January 2003 23:48, Arpi wrote:
> Hi,
>
> > afaik only vo_svga and vo_ggi supports BGR8, and both (should) use the
> > palette. otherwise it has no sense of supporting bgr8, as you said it
> > would show garbage.
>
> ehh
> vo_svga uses hardcoded palette:
>
>   /* set 332 palette for 8 bpp */
>   if(bpp==8){
>     int i;
>     for(i=0; i<256; i++)
>       vga_setpalette(i, ((i>>5)&7)*9, ((i>>2)&7)*9, (i&3)*21);
>   }
>
> who the fsck made it? (i'm lazy to browse cvslog:))
IIRC me, i added 8,4,1 bpp support to vo_svga, and i couldnt find a palette 
entry in mp_image_t so i assumed that there is no palette and didnt think any 
further about it (yes iam very stupid i know ...)

btw, IMHO, we should either document such hacks (like palette in the 2nd 
plane) or use a descriptive name like palete, IMHO the later is much better 
as all code which uses mp_image_t is much more readable then (img.plane[1] 
vs. img.palete) everyone knows what the 2nd one means, but only 3 or 4 ppl 
might know that plane[1] is the palete ...

[...]

Michael