[MPlayer-dev-eng] What is the format of 4bpp? (postproc/yuv2rgb

[Arpi]

Hi,

> > > IMHO we should not change the meaning of the formats, instead adding a
> > > new RG4P (rgb4 packed) is IMHO better
> >
> > hmm.
> > imho BGR4/RGB4 means 2 pixel/byte, because:
> > - mpi->bpp==4 for that format
> > - BGR1/RGB1 means 8 pixels/byte
> ok, agree, ill fix the yuv2rgb & swscaler
> 
> >
> > but i have no idea for a good name and/or fourcc for this 1pixel/byte
> > 16colorformat. maybe 1B16 ? :)
> RG4B (rgb4 byte type) 

ok.

btw, thinking about planes[1] vs. plalette, now i remember why was planes[1]
choosen long time ago. since mpi (mp_image_t) is an internal format of
mplayer, used only by codecs and filters in libmpcodecs/.
libvo and external filters (like your postproc/swscale stuff...) don't know
mpi but have char** planes pointer. so it could take/put palette from/to
planes[1] without having to introduce mpi or new fv parameter there.
the same applies to libvo, wiht the update that new libvo api has a new
(optional) fv called draw_image which passes mpi to the libvo driver so
if the given vo implements it then mpi->palette is doable.
note that the only 2 vo with <=8bpp support (svga,ggi) uses the old libvo api...

so i vote for keeping planes[1], at least until 0.90 released.


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu
    "However, many people beg for its inclusion in Debian. Why?" - Gabucino
  "Because having new software in Debian is good." - Josselin Mouette
"Because having good software in Debian is new." - Gabucino