[MPlayer-dev-eng] [PATCH] Three new filters and performance doubts

[Arpi]

Hi,

> denoise3d: I call it a "3d denoiser" and it's function is similar to a
> "smarth blur" followed by a "temporal denoiser", just it's quite faster,
> has understable parameters and, in my tests, the results are better.
> (better noise reduction with less ghosting/bluring) [BTW: default
> parameter for this filter should provide a good tryout]

Ok i'm about commiting this, but the code has some problems.
It ignores stride (bytes per line), both source and dest images
(it assumes width==stride which may be true, but for complex filter chains
or some vo drivers/codec it's false)

There is 2 way to fix:
- tell libmpcodecs core not to use stride (remove MP_IMGFLAG_ACCEPT_STRIDE
from get_image call, and reset VFCAP_ACCEPT_STRIDE from vf->default_caps
in config())
- fix your code to honor both mpi->stride[] and dmpi->stride[] (preferred)

maybe you should read DOCS/tech/libmpcodecs.txt


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu
    "However, many people beg for its inclusion in Debian. Why?" - Gabucino
  "Because having new software in Debian is good." - Josselin Mouette
"Because having good software in Debian is new." - Gabucino