[MPlayer-dev-eng] What is the format of 4bpp? (postproc/yuv2rgb

[Ivan Kalvachev]

Michael Niedermayer said:
> Hi
>
> On Thursday 30 January 2003 00:37, Arpi wrote:
>> Hi,
>>
>> > > > IMHO we should not change the meaning of the formats, instead
>> adding a new RG4P (rgb4 packed) is IMHO better
>> > >
>> > > hmm.
>> > > imho BGR4/RGB4 means 2 pixel/byte, because:
>> > > - mpi->bpp==4 for that format
>> > > - BGR1/RGB1 means 8 pixels/byte
>> >
>> > ok, agree, ill fix the yuv2rgb & swscaler
>> >
>> > > but i have no idea for a good name and/or fourcc for this
>> 1pixel/byte 16colorformat. maybe 1B16 ? :)
>> >
>> > RG4B (rgb4 byte type)
>>
>> ok.
> found another problem :(
> what about stuff like?
> #define isRGB(x)       (((x)&IMGFMT_RGB_MASK)==IMGFMT_RGB)
> it will need another || x==IMGFMT_RG4B
> we could missuse RGB3 or RGB7, but is it a good idea? the bpp is
> obviously  wrong ...

Well there is already one format that have 1pixel/byte - rgb8.
The only thing we have to do it to limit the colors. This way all paleted
formats fit in rgb8.

Well for now. Fix the scaler to use proper 4bpp. Save the old function in
same way so svga could use it (until i remove the svga with new one), this
should be easy as vo_svga calls yuv2rgb directly.

Ivan Kalvachev