[MPlayer-dev-eng] [PATCH] vf_eq2 extensions

[Michael Niedermayer]

Hi

On Friday 31 January 2003 14:24, Hampa Hug wrote:
> D Richard Felker III wrote:
> > On Fri, Jan 31, 2003 at 01:42:23AM +0100, Hampa Hug wrote:
> > > Daniel: I think it should be possible to combine vf_eq2 and your
> > > gamma patch into a single filter. This would then be a pretty
> > > complete equalizer.
> >
> > Pretty slow to! It'd be nice if you could put fast hue and saturation
> > code in vf_eq.c. Sat is really easy to add and hue can be done very
> > quickly with mmx.
>
> How is this going to be faster? I grant you that hue adjustment
> is slow. But it can be implemented in vf_eq2 as fast as in
> vf_eq.
>
> I am reluctant to put this stuff in vf_eq.c because the main
> function that I need (the main reason for vf_eq2 to exist) is
> gamma correction and that's the one thing that can't be done
> efficiently in vf_eq.c.
perhaps the eq & eq2 filters should be merged and then depending upon the user 
settings (gamma or not) a LUT based eq is used or the add/mul mmx/c stuff ...

[...]

Michael