[MPlayer-dev-eng] [PATCH] vf_eq2 extensions

[D Richard Felker III]

On Fri, Jan 31, 2003 at 02:24:41PM +0100, Hampa Hug wrote:
> D Richard Felker III wrote:
> 
> > On Fri, Jan 31, 2003 at 01:42:23AM +0100, Hampa Hug wrote:
> > > Daniel: I think it should be possible to combine vf_eq2 and your
> > > gamma patch into a single filter. This would then be a pretty
> > > complete equalizer.
> > 
> > Pretty slow to! It'd be nice if you could put fast hue and saturation
> > code in vf_eq.c. Sat is really easy to add and hue can be done very
> > quickly with mmx.
> 
> How is this going to be faster? I grant you that hue adjustment
> is slow. But it can be implemented in vf_eq2 as fast as in
> vf_eq.

Right, but the brightness/contrast parts will still be slow, so you'd
have to load both eq and eq2 to have everything be fast, which is
silly. eq2 is meant to be a lookup-table based filter mainly for
gamma, and the brightness/contrast are there because once you have a
lut it's easy to do all of that. On the other hand, eq is intended to
actually be usable.

> I am reluctant to put this stuff in vf_eq.c because the main
> function that I need (the main reason for vf_eq2 to exist) is
> gamma correction and that's the one thing that can't be done
> efficiently in vf_eq.c.

Hmm, someone should add polynomial approx gamma correction to eq then
so we can just make eq2 obsolete.

Rich