[MPlayer-dev-eng] [PATCH] cygwin dvd support working

[Diego Biurrun]

Joseph Parrish writes:
 > I've gotten cygwin mpdvdkit to work.  I began by updating to latest
 > libdvdread stable and then reviewing diffs.  Finally I isolated the
 > changes that fixed the problem I've had with cygwin mpdvdkit.  Attached
 > below is this patch.  I can send a much larger patch to update all of
 > mpdvdkit to latest dvdread/dvdcss sources, but it does not seem entirely
 > needed.
 > 
 > Now, I've recently lost my internet access, so this patch is totally
 > untested under linux.  It is also based on cvs from the ~16th of July.  I
 > expect it to work fine, but PLEASE TEST for me.  I can verify that it
 > works very well under win2k so far.
 > 
 > Also, I cannot commit this patch myself (no inet at home for about a
 > week), so if all is well then please commit it for me.  I have managed to
 > get this patch out of my house along with a new mplayer-cygwin package
 > based on the main tree this time.  I recommend playing with it to anyone
 > who is interested.  It is also mostly untested, which is why I want you to
 > play with it.  :)

I already committed this hunk to CVS:

--- main.sofar/libmpdvdkit2/device.c	2003-02-07 18:22:38.000000000 -0600
+++ main.dev/libmpdvdkit2/device.c	2003-07-18 11:11:46.000000000 -0500
@@ -135,7 +135,7 @@
 
 #if defined( WIN32 )
     /* If device is not "X:", we are actually opening a file. */
-    dvdcss->b_file = !psz_device[0] || psz_device[1] != ':' || psz_device[3];
+    dvdcss->b_file = !psz_device[0] || psz_device[1] != ':' || psz_device[2];
 
     /* Initialize readv temporary buffer */
     dvdcss->p_readv_buffer   = NULL;

You might also want to send your patch to mplayer-cygwin, you should
find more testers there.  Sylvain Petreolle is still having problems
with DVDs under Windows XP.

Diego