[MPlayer-dev-eng] [PATCH] EDL 0.6 - DVD chapter support (w/ cvs diff -u)

[Michael Halcrow]

On Fri, Jul 25, 2003 at 05:42:09PM +0200, Diego Biurrun wrote:
> Michael Halcrow writes:
>  > On Thu, Jul 24, 2003 at 09:42:55PM +0200, Arpi wrote:
>  > 
>  > This is a patch against main.  I've worked it over a bit more after
>  > more extensive testing since I submitted it the first time.
>  > 
>  > Let me know if you have any concerns about it.
> 
>  > +<P>Most DVD streams contain chapters.  MPlayer's timer resets to 0 at
>  > +the start of each chapter, and so just having seconds denote the
>  > +location is insufficient in these cases.  The modified EDL file format
>  > +for DVD streams is:</P>
> 
> minor nit:
> 
> You use (American style) two spaces after a period.  While I like this
> and also use it in mails etc, most of us are Europeans and accustomed
> to only one space.  So to conform strictly to our (unwritten) style
> guide you should also use only one space here.

I lived in Europe for two years (Italy from '97-'99), and this is yet
another nuance that I never picked up.  :-)

Do you want me to change this and resubmit the patch, or is the
current patch acceptable (and I keep this in mind for future patches)?

Mike

-- 
------------------------------------------- | ---------------------
Michael Halcrow                             | mike at halcrow.us     
Developer, IBM Linux Technology Center      |                      
                                            |
The hokey pokey... What if that's really    |
what it's all about?                        |
------------------------------------------- | ---------------------
GnuPG Keyprint:  05B5 08A8 713A 64C1 D35D  2371 2D3C FDDA 3EB6 601D
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20030725/1839aa5e/attachment.pgp>