[MPlayer-dev-eng] [PATCH] Autoconfiguration for XML DOCS building system

[Zoltan Hidvegi]

> Dmitry Baryshkov writes:
> You use things like
> 
>   if test "x$_catalog" != "x"
>   if test "x$_chunk_xsl" = "x"
> 
> which is OK, but 
> 
>   if test -n "$_catalog"
>   if test -z "$_chunk_xsl"
> 
> or if you prefer
> 
>   if [ -n "$_catalog" ]
>   if [ -z "$_chunk_xsl" ]
> 
> are simpler IMHO.  The creation of html.xsl etc are also simplified

Some old shells do not handle test -n "$foo" well if foo is some
binary operator, e.g. if foo is =, it will expand to test -n =, and
some shells think that you want to compate -n to =.  This cannot
happen in a POSIX shell, where the semantics of test is well-defined,
but some unixes still have the old bourne shell which is buggy.
Writing "x$foo" always works on all shells.

Zoli