[MPlayer-dev-eng] Re: [PATCH] Real Audio/Video DLL support for Mac OS X

[Donnie Smith]

On Sat, Jun 28, 2003 at 20:00:39 +0200, Diego Biurrun wrote:
> I vote for the error message plus the explanation in the docs.
Is patching DOCS/codecs.html fine with everyone? It's suitable
especially since "Read the RealVideo section of the DOCS!" is printed
when it fails to load the DLLs. I've attached a suggestion.

>  > I also found out the cause of the libiconv problems:
>  > libvo/font_load_ft.c uses iconv without checking HAVE_ICONV,
>  > guess font_load_ft.c's maintainer should fix the code... I'll check
>  > why the configure script fails to detect my iconv (I have it installed).
> Why don't you send in another patch? ;-)
The configure script was working (of course), it was I who forgot to
tell configure where it was installed :) .

Anyhow, I had a look at the code and I see no easy way to patch
libvo/font_load_ft.c, iconv is strictly needed where it's used.
The lazy way out would of course be to change all HAVE_FREETYPE to
defined(HAVE_FREETYPE) && defined(HAVE_ICONV), or change the
definition of HAVE_FREETYPE in configure. The downside of the latter
is that there are code that checks HAVE_FREETYPE and/or uses code from
libvo/font_load_ft.c that doesn't require iconv (mainly the Gui/
code).

The best solution would be, I think, to create another #define 
or change HAVE_FREETYPE to HAVE_FREETYPE && HAVE_ICONV _where needed_
and add a couple of #ifdef HAVE_ICONV to libvo/font_load_ft.c.

Donnie Smith
-------------- next part --------------
--- DOCS/en/codecs.html.orig	2003-06-30 13:39:24.000000000 +0200
+++ DOCS/en/codecs.html	2003-06-30 14:13:03.000000000 +0200
@@ -267,7 +267,16 @@
 
 <P><B>Note:</B> RealPlayer libraries currently <B>only work with Linux, FreeBSD,
   NetBSD and Cygwin on the x86, Alpha and PowerPC (Linux/Alpha and Linux/PowerPC
-  have been tested) platforms.</B></P>
+  have been tested) platforms and with Mac OS X.</B></P>
+<P>On Mac OS X you must make sure <CODE>pncrt.Shlb</CODE> (including it's
+  resource fork!) is in the same directory as the Real codecs.
+  Copy them using, for example, <CODE>ditto</CODE>:
+    <PRE>
+    ditto -rsrcFork "RealOne Player.app/Contents/MacOS/pncrt.Shlb" "RealOne Player.app/Contents/MacOS/Library/Codecs"</PRE>
+  Not doing this, or forgetting to copy the resource fork, will result in
+  errors such as: <CODE>GetDiskFragment() failed with error -2804:
+  &lt;&lt;Unknown disk fragment&gt;&gt;&lt;&lt;Unknown disk 
+  fragment&gt;&gt;&lt;pncrt.Shlb&gt;&lt;&gt;</CODE>.</P>
 
 
 <H4><A NAME="xvid">2.2.1.9 XviD</A></H4>