[MPlayer-dev-eng] patches

[Joey Parrish]

On Wed, Mar 05, 2003 at 04:35:40PM +0100, Michael Niedermayer wrote:
> this can only be bad if a patch is bad and it isnt rejected for 1 week (or 
> longer if the we agree on a longer timespan, perhaps 1 month would be more 
> reasonable as some devels might be busy/away for a while)
> and this can only happen if either
> noone looked at the patch or noone understands the patched part or ppl are
> too lazy to say that its bad

> i dont really belive that noone looks at the patches, as its much more 
> difficult to write them then to quickly look at them ...
> and if noone understands the given part of mplayer then applying the patch & 
> seeing things break will improve the understanding IMHO ;) and it will then 
> either be fixed or reversed 
> and the knowledgde that a patch will be applied if noone says that its bad 
> will very likely decrease the number of ppl who review a patch & then do 
> nothing

I agree.  When I send patches, sometimes there is no response.  It
leaves me to wonder if this means that my patch is bad, or people are
busy, or maybe it will be silently applied and I have to watch when I
cvs update to see if it's in.  Having a standard for how to treat a new
patch would make things much easier on people who send them.  We would
not have to worry or wonder what is going on with the core developers.

Thanks,
--Joey