[MPlayer-dev-eng] [PATCH] resubmit realv4.diff
Arpi
arpi at thot.banki.hu
Thu Mar 6 23:38:25 CET 2003
Hi,
> > I resubmit in case you forgot.
> hmm IIRC arpi didnt like it
yes...
i was about applying it to main, but i wante dto test it first that it
doens't break more than it fixes. unfortunatelly i couldn't manage it yet
(it took me weeks to transfer mphq ftp to home and since that i'm too busy
and anyway playing tons of silly .rm files and concentrating to a-v sync
is so boring...:))
> 0x303?5652 should perhaps be replaced with #defined values or add some
it's the fourcc in hex
maybe MMIO_FOURCC() macro could be used here...
> rv_version variable perhaps, yes its allready there before your patch but it
> makes reviewing the patch more difficult
afair rv_version is obsolete, and (should be) unused.
it wa added by alex to make difference between rv10 versions but since we
pass the headers to ffmpeg it is unneeded.
> the kf change from *2 to *4 looks like some additional bit has been inserted,
> in which case this would be wrong
agree
> + if( ( ( s[0] & (~0xf) ) ==0 ) || ( ( s[0] & (~0xf) ) ==0x40 ) ||
> + ( ( s[0] & (~0xf) ) ==0x50 ) || ( ( s[0] & (~0x7) ) ==0x10 ) ){
> this should be replaced by a simple 2 bit check as arpi said
agree
> + float tmp=sh->fps;
> sh->fps = stream_read_word(demuxer->stream);
> + if (sh->fps<=0) sh->fps=tmp;
> sh->frametime = 1.0f/sh->fps;
> why not
> int fps2= stream_read_word(demuxer->stream);
> if (fps2>0) sh->fps= fps2;
> sh->frametime = 1.0f/sh->fps;
or:
int fps2= stream_read_word(demuxer->stream);
if (fps2>0){ sh->fps= fps2; sh->frametime = 1.0f/fps2; }
A'rpi / Astral & ESP-team
--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu
"However, many people beg for its inclusion in Debian. Why?" - Gabucino
"Because having new software in Debian is good." - Josselin Mouette
"Because having good software in Debian is new." - Gabucino
More information about the MPlayer-dev-eng
mailing list