[MPlayer-dev-eng] [PATCH] resubmit realv4.diff

[Michael Niedermayer]

Hi

On Friday 07 March 2003 00:11, Balatoni Denes wrote:
> Hi!
>
> > 0x303?5652 should perhaps be replaced with #defined values or add some
> > rv_version variable perhaps, yes its allready there before your patch but
> > it makes reviewing the patch more difficult
>
> I will change that to the fourcc macro Arpi proposed. Probably in this
> century, when I have time.
>
> > the kf change from *2 to *4 looks like some additional bit has been
> > inserted, in which case this would be wrong
>
> could be. well the patch is an enhancement to rv30/40 demuxing, but of
> course still not perfect (and I am not sure it will ever be). i thought if
> it's in the repository others can look at it too, and improve it. Some
> (most??) rv30/40 videos have correct a-v sync with the patch. rv20/10 is
> worse than before in some cases (choppy, but I actually didn't find it that
> bad, ymmv)
>
> Sure there is huge room to improve still.
>
> > +  if( ( ( s[0] & (~0xf) ) ==0 ) || ( ( s[0] & (~0xf) ) ==0x40 ) ||
> > +     ( ( s[0] & (~0xf) ) ==0x50 ) || ( ( s[0] & (~0x7) ) ==0x10 ) ){
> > this should be replaced by a simple 2 bit check as arpi said
>
> okay. like
> (s[0]<0x18) || ((s[0]>>5)==2)   ?
no, i fixed it in cvs, so pict_type & kf is (IMHO) correctly read but i just 
tried it with 1 rv40 & 1 rv30 file ...

[...]

Michael