[MPlayer-dev-eng] [PATCH] resubmit realv4.diff

Arpi arpi at thot.banki.hu
Fri Mar 7 11:08:51 CET 2003


Hi,

> Also this:
> -			    if(dp_data[dp_hdr->len]&0x20) --dp_hdr->chunks; else
> +			    if((dp_data[dp_hdr->len]&0x20) && (sh_video->format!=0x30345652)) 
> --dp_hdr->chunks; else
> 
> to fix rv40 frames cut in the middle.

imho it's bad fix.
if they are cut in middle, it means that rv40 stores number_of_chunks/4
in header byte (probably to allow up to 4*64==256 slices) instead of
number_of_chunks/2 like in rv20/rv30.

> And this:
> -    for (i = 1; i < num_of_headers; i++)
> +    for (;;)
> 
> as num_of_headers is a random number sometimes

it shouldn't be random. maybe it is for streamed media, causing that
-dumpstream'ed files aren't playable even with realplayer.

but i have no better idea to fix

> Also there was a patch to vd_real, to ask the codec first how big the decoded 
> frame is, before initializing vo - fixed Pen3.rm and Noir.rm and dt???.rm on 
> ftp.

it was a very ugly hack.
(malloc'ing a buffer, decoding there, init vo, get_image, memcpy...)


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu
    "However, many people beg for its inclusion in Debian. Why?" - Gabucino
  "Because having new software in Debian is good." - Josselin Mouette
"Because having good software in Debian is new." - Gabucino


More information about the MPlayer-dev-eng mailing list