[MPlayer-dev-eng] [PATCH] Add license to radeonfb.c
Arne Driescher
driescher at mpi-magdeburg.mpg.de
Mon Mar 10 09:08:10 CET 2003
On Saturday 08 March 2003 17:54, you wrote:
> Hi,
> loading modules without license will taint the kernel. radeonfb.c is
> missing MODULE_LICENSE, the fix is trivial:
>
> --- mplayer-cvs/drivers/radeon/radeonfb.c~ Mon Jan 13 19:34:52 2003
> +++ mplayer-cvs/drivers/radeon/radeonfb.c Sat Mar 8 17:38:30 2003
> @@ -105,6 +105,7 @@
>
> MODULE_AUTHOR("Ani Joshi. (Radeon VE extensions by Nick Kurshev)");
> MODULE_DESCRIPTION("framebuffer driver for ATI Radeon chipset. Ver:
> "RADEON_VERSION); +MODULE_LICENSE("GPL");
> #ifdef CONFIG_MTRR
> MODULE_PARM(nomtrr, "i");
> MODULE_PARM_DESC(nomtrr, "Don't touch MTRR (touch=0(default))");
>
>
> ciao,
> Luca
Have you tested to compile it with an older kernel version?
I have not but afaik MODULE_LICENSE is not in the
old 2.4.x kernel. Try at least something like
#ifdef MODULE_LICENSE
MODULE_LICENSE("GPL")
#endif
or better find out what kernel version actually
requires this.
-Arne
More information about the MPlayer-dev-eng
mailing list