[MPlayer-dev-eng] [PATCH] Add license to radeonfb.c

[Arne Driescher]

In generall, it looks good to me.

Personally, I would prefere a solution (as e.g. Rubini does for his stuff)
that puts kernel version dependencies into a header file
and this header file is included into all modules so that maintenance
is easier and the source tree is not cluttered by #ifdef XXX. 
In my own drivers I use the original file sysdep.h from
Rubinies driver book and additionally a sysdep_ext.h where I put
things not covered by Rubini. Lazy as I am I than copy Rubinis
file to my repository every time he publishes a new version
without bothering to merge the changes.

But my personal tast is of no relevance in this case.

Greetings,
Arne


On Monday 10 March 2003 19:33, you wrote:
> Il Mon, Mar 10, 2003 at 09:08:10AM +0100, Arne Driescher ha scritto:
> > I have not but afaik MODULE_LICENSE is not in the
> > old 2.4.x kernel.
>
> You are right, MODULE_LICENSE was added in 2.4.9. What about this:
>
> --- radeonfb.c~	Mon Jan 13 11:08:21 2003
> +++ radeonfb.c	Mon Mar 10 19:31:49 2003
> @@ -105,6 +105,10 @@
>
>  MODULE_AUTHOR("Ani Joshi. (Radeon VE extensions by Nick Kurshev)");
>  MODULE_DESCRIPTION("framebuffer driver for ATI Radeon chipset. Ver:
> "RADEON_VERSION); +/* MODULE_LICENSE requires kernel version >= 2.4.9 */
> +#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,4,9)
> +MODULE_LICENSE("GPL");
> +#endif
>  #ifdef CONFIG_MTRR
>  MODULE_PARM(nomtrr, "i");
>  MODULE_PARM_DESC(nomtrr, "Don't touch MTRR (touch=0(default))");
> --- radeon_vid.c~	Thu Jul 25 15:38:14 2002
> +++ radeon_vid.c	Mon Mar 10 19:32:14 2003
> @@ -78,7 +78,8 @@
>  #else
>  MODULE_DESCRIPTION("Accelerated YUV BES driver for Radeons. Version:
> "RADEON_VID_VERSION); #endif
> -#ifdef MODULE_LICENSE
> +/* MODULE_LICENSE requires kernel version >= 2.4.9 */
> +#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,4,9)
>  MODULE_LICENSE("GPL");
>  #endif
>  #ifdef CONFIG_MTRR
>
> ciao,
> Luca