[MPlayer-dev-eng] [PATCH] support for hardware mjpeg encoding in tvi_v4l.c (version 3)

[D Richard Felker III]

On Thu, Mar 13, 2003 at 03:09:16AM +0100, Ivan Szanto wrote:
> Hi Rich,
> 
> 
> thank you for the correction:
> 
> > On Wed, Mar 12, 2003 at 01:32:35AM +0100, Ivan Szanto wrote:
> > > +.IPs decimation
> > > +choose the size of the picture that will be compressed by hardware
> > > +mjpeg compression:
> > > +.RSss
> > > +1: big size: 704x576
> > > +.br
> > > +2: medium size: 352x288
> > > +.br
> > > +4: small size: 176x144
> >
> > These numbers are only valid for PAL. NTSC should be 704x480, 352x240,
> > and 176x120.
> 
> You are right (at least I hope you are ;-), cause I now used that data)
> 
> But I'm a little bit in doubt. In patches.txt it does not actually
> say that I should implement everything in one go. In the previous
> versions of this patch (v1 and v2), PAL was implemented, NTSC was not,
> since I cannot test NTSC. Is this now a reason not to commit my patch?

Oh, I just assumed NTSC would work in the code but that you left out
the NTSC info in the manual. If I'm mistaken on that, ignore my
complaint. It should be ok to commit anyway and someone can fix NTSC
later.

I don't have an mjpeg card tho, so it's best if someone else tests and
commits it.

> Anyway, I made the change to the manpage and to the code, so v3 (see
> below) should now support NTSC. (=please disregard v1 and v2 of this
> patch)

Ah, cool, I should have read your full message.

Rich