[MPlayer-dev-eng] -menu & pause bug fix?

[Vladimir Mosgalin]

This is regarding menu & pause bug (well, at least I think it is bug):
--- cut ---
1) Bug with menu. Run mplayer -menu <some-file>, and pause key will
   start working strangely - every first press will be lost, but when
   you press menu key, pause activates. After it everything repeats.
   This makes -menu really unusable..
--- cut ---

I tried to discover what causes that, and that was too easy... When I
remove 4 lines from vf_menu.c (see patch), pause starts working as
expected. The problem is, this seems to be dumb - these lines were
responsible for something... I can't even imagine such behavior was made
on purpose. I tested patch, it breaks nothing for me, but now I can run
mplayer with menu=on without problems.

-- 

Vladimir
-------------- next part --------------
--- MPlayer-0.90rc5/libmenu/vf_menu.c.orig	Sun Mar 23 00:00:56 2003
+++ MPlayer-0.90rc5/libmenu/vf_menu.c	Sat Mar 22 23:49:37 2003
@@ -85,10 +85,6 @@
 
   switch(cmd->id) {
   case MP_CMD_PAUSE :
-    if(!paused && !go2pause) { // Initial pause cmd -> wait the next put_image
-      go2pause = 1;
-      return 1;
-    }
     if(go2pause == 2) // Msg resent by put_image after saving the image
       go2pause = 0;
     break;