[MPlayer-dev-eng] Offer of help to get me started

[Evil Kosh]

Hello Rich,

no, I'm not trolling the list, I'm serious.  IMHO I started to read the
source and found that people were using spaces here, tabs there,
sometimes the brace would be after the if/switch/for statement on the
same line, others would have it below, others wouldnt have one at all.

like I've said, the linux kernel has a style guide and it helps
enormously.  People can read it, produce code according to it and
submit, there are no issues with style or hacking, everyone knows what
to expect and what the official line is.

It's like taking the personal touch away from code and trying to be
professional about it, without trying to say you are not being
unprofessional.  If everyone is allowed to just hack what they like,
they will do so and eventually the code is spaghetti.

I am offering to update the code with a style, which can then be updated
by you guys too which will give us all what we want.  It doesnt cost you
anything does it?

It helps people like me, who want to help, but find the code hard to
read and eventually give up.  By doing this, I can help, improve the
quality of the code layout and possibly could help more people to
contrbute by removing this (invisible)barrier.

I'm not trying to be a bastard, or start fights, I'm simply trying to
help in a way that I can.

kosh

On Mon, 2003-03-24 at 00:00, D Richard Felker III wrote:
> On Mon, Mar 24, 2003 at 01:08:03AM +0100, Arpi wrote:
> > Hi,
> > 
> > > Evil Kosh writes:
> > >  > 	Would anyone here object to a clear style guide being formed from the
> > >  > developers here?  I'd be happy to reformat the code along those
> > >  > guidelines, if it means I can help out, everyone gets clear, well
> > >  > formatted code along an agreed style.
> > > 
> > > Arpi dislikes style guidelines and has refused them in the past.  Now
> > 
> > with reason...
> > 
> > imho it's a very bad idea (although very common) to force a given
> > indentation/coding style to every developers.
> > if someone wants to look at the code in a given indent/style, he can run
> > 'indent' on the tree anytime. i see no reason for messing up the cvs with
> > cosmetics.
> > 
> > but as diego mentioned, i don't play any more, so do what you want.
> > just my 0.02 Forint or something :)
> 
> I'm all for keeping the existing policy. BTW, was this guy serious or
> was he just trolling the list?
> 
> Rich
> 
> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
> http://mplayerhq.hu/mailman/listinfo/mplayer-dev-eng
-- 
Evil Kosh <evil_kosh_uk at yahoo.co.uk>