[MPlayer-dev-eng] Offer of help to get me started

[Evil Kosh]

On Mon, 2003-03-24 at 00:41, Diego Biurrun wrote:
> Arpi writes:
>  > > Arpi dislikes style guidelines and has refused them in the past.  Now
>  > 
>  > with reason...
> 
> of course
> 
>  > imho it's a very bad idea (although very common) to force a given
>  > indentation/coding style to every developers.
> 
> You have a point here, especially in a project such as MPlayer where
> some developers only modify small areas of the code.
> 
> But I think the problem lies in files that are inconsistent with
> themselves and mix several different styles.  That is the worst of
> both worlds IMHO.

yes, yes, this is exactly what I mean, one file, written in this style
and another, written in another style is fine imho, but one file,
written with all sorts of styles is hard to read, however good at C you
are.

> 
>  > if someone wants to look at the code in a given indent/style, he can run
>  > 'indent' on the tree anytime. i see no reason for messing up the cvs with
>  > cosmetics.
> 
> For the documentation we are following a coding style and all the
> contributors are happier with it than before.  The problem of bloated
> cvs logs/diffs can be addressed by strictly splitting off cosmetics
> from "real" commits, like we do with the docs.

well there is only so much code that needs reformatting until we are at
a stage where we all agree and understand each other.  Then the logs
decrease in size and we are all better for it.  It's a temporary
transition, as long as people from a point in time write code in a
particular style, there will be no need to reformat it.

>  > but as diego mentioned, i don't play any more, so do what you want.
>  > just my 0.02 Forint or something :)
> 
> :)
> 
> Diego
> 
> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
> http://mplayerhq.hu/mailman/listinfo/mplayer-dev-eng
-- 
Evil Kosh <evil_kosh_uk at yahoo.co.uk>