[MPlayer-dev-eng] Offer of help to get me started

[Diego Biurrun]

Arpi writes:
 > > For the documentation we are following a coding style and all the
 > > contributors are happier with it than before.  The problem of bloated
 > > cvs logs/diffs can be addressed by strictly splitting off cosmetics
 > > from "real" commits, like we do with the docs.
 > 
 > also have to mention that many of the files in mplayer source tree are from
 > other projects. for example, pnm.c is from xine, files at loader/ from
 > avifile, and so on. many files are often diff'ed to the originals and merged
 > teh changes to and back. if you reformat them, it makes diff'ing harder (yes
 > i know that diff has -b -B etc options but they do't wrok as good as they
 > should, and they cannot handle { moving to next line after if()).
 > note, that there are even files which are only partially from other
 > projects, some even mixed from multiple files, causing the file having
 > multiple indent/style...

Good point.  We should restrict ourselves to MPlayer specific files then.

 > (i don't even mention that i do diff'ing between 0_90 and main trees often
 > to port the changes between teh 2 tree, it will also go by a cosmetics patch)

Good point also, but I assume that at some point in the future this
will become irrelevant and we might break "backwards compatibility"
without doing much damage.  How long do you expect to maintain 0.90?

 > so, think it twice (or more) before decide to mess up cvs, please.

When I said this point should be reevaluated I did not mean to imply
that the policy had to be changed.  Now is the moment to rethink all
things.  It does not necessarily follow that we change our rules.  We
may come to the same conclusions again for the same (or different)
reasons.

Diego